Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 )
Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ......................................................................
Patch Set 1:
(3 comments)
File include/osmocom/vty/command.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-683): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/67fb4827_559acc14 PS1, Line 445: vector cmd_describe_command(vector vline, struct vty * vty, int *status); "foo * bar" should be "foo *bar"
File src/select.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-683): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/dd53efbb_42466ed6 PS1, Line 669: bool osmo_select_shutdown_done(void) { open brace '{' following function definitions go on the next line
File src/vty/cpu_sched_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-683): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/4822a614_18d4da93 PS1, Line 92: static int get_num_cpus(void) { open brace '{' following function definitions go on the next line