Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 ) Change subject: trx TCH DL: transmit invalid speech frames instead of dummy FACCH ...................................................................... Patch Set 1: (2 comments) File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/fa2297b7_925e210c PS1, Line 500: what is the correct BTS Tx behavior for frame : * gaps in TCH/AFS Please read the comment I just added under that ticket. Basically the short version is that I consider myself qualified only to work on FR/HR/EFR, i.e., make code improvements for these 3 codecs and review other developers' changes where they affect these non-AMR codecs. When it comes to AMR, I do not feel so qualified, hence I have to defer to other developers for whom AMR is a higher priority than it is for me. If you (fixeria) or any other developer has a solution in mind for AMR (doing something better than transmitting dummy FACCH, especially on TCH/H), perhaps you can implement it as a follow-on patch after my fix for FR/HR/EFR? https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/600dc842_02da4934 PS1, Line 505: gsm0503_tch_fr_encode I will look into implementing your suggestion in the next revision of my patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe Gerrit-Change-Number: 33069 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 May 2023 18:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment