Attention is currently required from: fixeria.
2 comments:
File src/osmo-bts-trx/sched_lchan_tchf.c:
what is the correct BTS Tx behavior for frame
* gaps in TCH/AFS
I guess we could indicate a bad frame via AMR's in-band signalling? Just an idea. […]
Please read the comment I just added under that ticket. Basically the short version is that I consider myself qualified only to work on FR/HR/EFR, i.e., make code improvements for these 3 codecs and review other developers' changes where they affect these non-AMR codecs. When it comes to AMR, I do not feel so qualified, hence I have to defer to other developers for whom AMR is a higher priority than it is for me. If you (fixeria) or any other developer has a solution in mind for AMR (doing something better than transmitting dummy FACCH, especially on TCH/H), perhaps you can implement it as a follow-on patch after my fix for FR/HR/EFR?
Patch Set #1, Line 505: gsm0503_tch_fr_encode
I suggest using a switch here: […]
I will look into implementing your suggestion in the next revision of my patch.
To view, visit change 33069. To unsubscribe, or for help writing mail filters, visit settings.