Attention is currently required from: arehbein, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 )
Change subject: gsm_objclass2mo(): Change signature/set NACK cause
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/334dec78_64f9c522
PS3, Line 11: Change dependency can be removed if we adapt the function
line length...
This was already fixed in the latest patchset version.
File include/osmo-bts/oml.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/7f7a6476_e42a7a99
PS7, Line 80: stru
not really the kind of coding style we use in osmocom, except for osmo-e1d which was written by tnt? […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32075
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5
Gerrit-Change-Number: 32075
Gerrit-PatchSet: 7
Gerrit-Owner: arehbein
arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: arehbein
arehbein@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 28 Apr 2023 19:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment