Attention is currently required from: neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31319 ) Change subject: misdn driver: printf and fprintf are replaced by logging functions ...................................................................... Patch Set 2: (1 comment) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31319/comment/434e68c1_ffe05a13 PS2, Line 728: fprintf(stdout, "activate bchan\n"); Sending activation message is something that is required (and always done) after opening a B-channel to use it, so I don't see a reason to show that in the debug. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6 Gerrit-Change-Number: 31319 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Feb 2023 17:08:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment