Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 )
Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
so I guess the only problem with the code is that osmo_amr_rtp_dec() always returns a CMR, as the CMR is a mandatory field of the RTP frame.
The intent was probably to check if a _new_ (different from current) CMR was being instructed, and then disable the loop until we receive frames with the same CMR.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/27777
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c
Gerrit-Change-Number: 27777
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 14 Apr 2022 15:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment