Attention is currently required from: neels, laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33500
)
Change subject: ASCI: Allow usage of rtp_stream with other FSM
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/33500/comment/5f1aa0e7_118e66c3
PS6, Line 13: Drop the unused parent_call_leg member.
This is probably another patch.
Removing the
parant_call_leg is part of the patch, so it does not depend on call_leg anymore. Dropping
this member is just one line that is changed. Is it really worth another patch?
File include/osmocom/msc/rtp_stream.h:
https://gerrit.osmocom.org/c/osmo-msc/+/33500/comment/f0d50064_068229f7
PS6, Line 29: uint32_t avail_event;
what about naming all of them ev_* or event_*. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33500
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0991927b6d00da08dfd455980645e68281a73a9e
Gerrit-Change-Number: 33500
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jul 2023 11:25:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment