Attention is currently required from: osmith, laforge.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 )
Change subject: ctrl: add optional port to bind command
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS7:
Marked *dynip() functions as deprecated and ported older ctrl_interface_setup() to the new function which uses port value from vty config.
File src/ctrl/control_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/95229f74_9183651b
PS5, Line 34: "bind A.B.C.D [<0-65535>]",
in the VTY case, IMHO the idea was that the "usual" caller of vty_bind_get_port() is inside libosmov […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30444
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9
Gerrit-Change-Number: 30444
Gerrit-PatchSet: 7
Gerrit-Owner: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Sat, 17 Dec 2022 14:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Gerrit-MessageType: comment