Attention is currently required from: laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33092 )

Change subject: libosmogsm: Factor out the C2 derivation function ......................................................................

Patch Set 4:

(2 comments)

File src/gsm/auth_core.c:

https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/0237ede1_29c4a45e PS4, Line 364: param[in] missing param name (syntax error), please add `sres_deriv_func`

https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/9d3f49fc_1a9c0115 PS4, Line 372: memcpy(xres, res, res_len); maybe do `OSMO_ASSERT(res_len <= sizeof(xres))` before calling `memcpy()`? or do `memcpy(xres, res, OSMO_MIN(res_len, sizeof(xres)))`?