pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35673?usp=email ) Change subject: gsup_server: Use new GSUP Cause defines from osmo_gsup ...................................................................... gsup_server: Use new GSUP Cause defines from osmo_gsup Change-Id: Ie19a0d0b81e0a264401ea37e0cfd74802aee68fe --- M rebar.lock M src/gsup_server.erl 2 files changed, 15 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/rebar.lock b/rebar.lock index d74d179..a542cbc 100644 --- a/rebar.lock +++ b/rebar.lock @@ -12,7 +12,7 @@ 0}, {<<"osmo_gsup">>, {git,"https://gerrit.osmocom.org/erlang/osmo_gsup", - {ref,"1a064fa6aece492352271ae164b29262d66f6b6d"}}, + {ref,"1391d074f610e736368319d56fd958fa36e3addf"}}, 0}, {<<"osmo_ss7">>, {git,"https://gitea.osmocom.org/erlang/osmo_ss7", diff --git a/src/gsup_server.erl b/src/gsup_server.erl index 5fe227c..a110b40 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -129,7 +129,7 @@ imsi => list_to_binary(Mar#'MAA'.'User-Name'), auth_tuples => lists:map(fun dia_sip2gsup/1, SipAuthTuples) }; - {error, _} -> Resp = #{message_type => send_auth_info_err, imsi => Imsi, message_class => 5, cause => 16#11} + {error, _} -> Resp = #{message_type => send_auth_info_err, imsi => Imsi, message_class => 5, cause => ?GSUP_CAUSE_NET_FAIL} end, lager:info("GSUP: Tx ~p~n", [Resp]), ipa_proto:send(Socket, ?IPAC_PROTO_EXT_GSUP, Resp), @@ -146,7 +146,7 @@ {error, _} -> Resp = #{message_type => location_upd_err, imsi => Imsi, message_class => 5, - cause => 16#11 % FIXME: Use proper defines as cause code and use Network failure + cause => ?GSUP_CAUSE_NET_FAIL } end, lager:info("GSUP: Tx ~p~n", [Resp]), @@ -178,7 +178,7 @@ Resp = #{message_type => epdg_tunnel_error, imsi => Imsi, message_class => 5, - cause => 16#11 % FIXME: Use proper defines as cause code and use Network failure + cause => ?GSUP_CAUSE_NET_FAIL } end, lager:info("GSUP: Tx ~p~n", [Resp]), @@ -221,7 +221,7 @@ Resp = #{message_type => location_upd_err, imsi => Imsi, message_class => 5, - cause => 16#11 % FIXME: Use proper defines as cause code and use Network failure + cause => ?GSUP_CAUSE_IMSI_UNKNOWN }, lager:info("GSUP: Tx ~p~n", [Resp]), ipa_proto:send(Socket, ?IPAC_PROTO_EXT_GSUP, Resp) @@ -240,7 +240,7 @@ Resp = #{message_type => epdg_tunnel_error, imsi => Imsi, message_class => 5, - cause => 16#11 % FIXME: Use proper defines as cause code and use Network failure + cause => ?GSUP_CAUSE_IMSI_UNKNOWN }, lager:info("GSUP: Tx ~p~n", [Resp]), ipa_proto:send(Socket, ?IPAC_PROTO_EXT_GSUP, Resp) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ie19a0d0b81e0a264401ea37e0cfd74802aee68fe Gerrit-Change-Number: 35673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged