Attention is currently required from: lynxis lazus, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email )
Change subject: Use new 'pre-create tundev' feature from gtp_u_kmod
......................................................................
Patch Set 3:
(2 comments)
File Makefile:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993/comment/e08caa03_0db1…
PS3, Line 32: run-test:
how about moving all commands to a separate shell script, and running that with sudo?
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993/comment/a4024a46_3577…
PS3, Line 39: sudo killall $(GTP_LINK) || true
kill only the specific GTP_LINK instance that was started, by using the pid? (if you move
everything into a shell script, it runs inside the same shell and you could use the MYPID
variable)
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e
Gerrit-Change-Number: 35993
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 16 Feb 2024 10:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment