Attention is currently required from: Hoernchen, Timur Davydov, fixeria, osmith.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: add --disable-multi-arfcn configure option ......................................................................
Patch Set 6:
(3 comments)
File Transceiver52M/arch/common/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/79153ce1_5209049a?usp=... : PS6, Line 9: mult.h fyi, you can usually do this to avoid touching too many lines with each patch:
mult.h \ $(NULL)
File Transceiver52M/radioInterface.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/9d3dbe0f_13f1a221?usp=... : PS6, Line 165: #ifdef ENABLE_MULTI_ARFCN What about splitting this subclass into a separate header instead in a previous commit?
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/13268275_548b0081?usp=... : PS6, Line 308: AC_DEFINE([ENABLE_MULTI_ARFCN],[1],[Building with enabled Multi ARFCN]) Please indent these 2 lines.
-
pespin