[S] Change in libosmocore[master]: osmo_io: Document expectation that segmentation_cb() can modify msgb - gerrit-log

12 Jul 2023


      Attention is currently required from: neels.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33685 )
Change subject: osmo_io: Document expectation that segmentation_cb() can modify msgb
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/33685/comment/a3a7ad7d_fbb4ac85 
PS1, Line 50: will be trimmed to size
...
i find it ambiguous: is this something that always happens before/after calling segmentation_cb(), o […]
I tried to clarify it in the documentation. segmentation_cb() itself doesn't split up anything, the calling function does that.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd2115baae98a7818aabb26232d4423d2d48fb5c
Gerrit-Change-Number: 33685
Gerrit-PatchSet: 2
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Wed, 12 Jul 2023 09:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Gerrit-MessageType: comment