Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27218 ) Change subject: libosmo-tlv: add auto dec/enc to/from structs ...................................................................... Patch Set 1: (2 comments) File include/osmocom/tlv/tlv_dec_enc.h: https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/e240fd96_68a88369 PS1, Line 60: OSMO_TLV_NESTED_IES_ORDERED_SAME = 0, This is not really clear. What's the difference between ORDERED_SAME and ORDERED? https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/421a08a9_42697e5d PS1, Line 135: * In this example, the nested IEs decode/encode to different goo sub structs depending on the tag value. goo? the table game? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I65de793105882a452124ee58adb0e58469e6e796 Gerrit-Change-Number: 27218 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Feb 2022 13:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment