Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email )
Change subject: bsc: add test TC_si2_ncc_permitted
......................................................................
Patch Set 1:
(2 comments)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542/comment/f145fe2f_6b30…
PS1, Line 12399: System Information Type 2
btw, this IE is also present in SI Type 6. […]
Currently it seems OsmoBSC is not sending SI 6 in the test. I've spent quite
some time looking into it, but don't see why it isn't sending it. It prepares the
message:
```
GSMTAP libosmocore logging OsmoBSC(7): RR/1: bts_trx.c:378 SI6: 2d 06 1e 00 00 00 f1 10 00
01 97 e0 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b
```
Also we don't have existing tests for SI6.
I've added a TODO.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542/comment/24634a84_6a12…
PS1, Line 12798: TC_ncc_permitted_si2
How about naming this testcase `TC_si2_ncc_permitted`
and moving closer to other `TC_si*` testcases […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibff5c4392d8c19b5bce479b6fa5e33086cdb1272
Gerrit-Change-Number: 34542
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Sep 2023 17:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment