osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33360 )
Change subject: Cosmetic: gsm48_cc_tx_setup: remove TODO comment ......................................................................
Cosmetic: gsm48_cc_tx_setup: remove TODO comment
Remove the comment as trans->bearer_cap will be used in CSD code to differentiate between speech and data.
Related: OS#4394 Change-Id: I0539632f464bc44945599bec52dc2a4df2f0115f --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/60/33360/1
diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 9670db0..773ee3d 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -840,8 +840,6 @@ return rc; } /* Create a copy of the bearer capability in the transaction struct, so we can use this information later */ - /* TODO: we should be able to drop trans->bearer_cap, replaced by the codecs filter. Verify this. - * So far let's just store it there like previous code did. */ trans->bearer_cap = bearer_cap; /* If no resulting codecs remain, error out. We cannot find a codec that matches both call legs. If the MGW were * able to transcode, we could use non-identical codecs on each conn of the MGW endpoint, but we are aiming for