Attention is currently required from: msuraev.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/32400 )
Change subject: e1_input: add new driver callback function: line_create
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-abis/+/32400/comment/babd4388_cbe09c04
PS4, Line 14: moment is no way to do that, so lets add a line_create callback that,
"moment there is no way" sounds better
Done
File src/e1_input.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/32400/comment/08f53764_d379ce44
PS4, Line 646: return NULL;
That looks pretty important - shouldn't we log
smth to let lib user know why the line wasn't created […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/32400
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I404fa23e9b8a952be84e9716889c0dbbbc665d22
Gerrit-Change-Number: 32400
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 May 2023 13:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment