Attention is currently required from: falconia.
keith has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email )
Change subject: trau_frame: add support for config frames of 3GPP Rel5+
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
I can't speak to the accuracy of the en/decode functions as I have not studied the
spec, but the author tends to know.. and I can't see how this can hurt
File src/trau/trau_frame.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/41210/comment/cd301384_d1b270fc… :
PS1, Line 1371: * exception of newly added OSMO_TRAU16_FT_CONFIG, and for
OSMO_TRAU8_SPEECH
This comment will not age well. 😊
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ifbde07e4a3fb80e4faa0b6a6b32938ed98371c5b
Gerrit-Change-Number: 41210
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Sat, 11 Oct 2025 03:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes