[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. - gerrit-log

12 Nov 2024


      Attention is currently required from: JPM, dexter, fixeria.
laforge has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )
Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/c5fd01f3_3ad03... :
PS1, Line 8: Adding test_plmn_adapter.
...
Commit summary should be one line followed by an empty line. I would remove this one.
Done
https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/edea6269_a3621... :
PS1, Line 10: Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376
...
Add `Related: pysim. […]
Done
-- 
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376
Gerrit-Change-Number: 38687
Gerrit-PatchSet: 5
Gerrit-Owner: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 12 Nov 2024 12:54:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de