Attention is currently required from: jolly, osmith. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37799?usp=email ) Change subject: osmotestconfig: fix return value of write_config() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File scripts/osmotestconfig.py: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37799/comment/9a01e… : PS1, Line 33: if test_config_atest(app_desc, newconfig, write_config, verbose) > 0: For reviewers: the only caller is here. As can be seen, it expects an integer (not tuple). -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I24adfd344937bab1ab641327e59a25bf76e18591 Gerrit-Change-Number: 37799 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 12 Aug 2024 17:12:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes