Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454?usp=email )
Change subject: ran-emu: allow receiving Paging without a TMSI
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454/comment/ecfb31fe_9ba8…
PS1, Line 507: var template OCT4 tmsi := omit;
let's focus on technical reasoning. […]
In
this specific case I agree with Neels. `f_imsi_table_find` accepts `template OCT4 tmsi`,
so applying the `(omit)` restriction does not make a big difference here. Closing this
thread, LGTM after all.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36454?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1bdf3488be0f8d4f0905665c4ba642f9468b9777
Gerrit-Change-Number: 36454
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 14 Apr 2024 13:09:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment