osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email ) Change subject: pfcp-tool: always use specific PDR ids for access and core ...................................................................... pfcp-tool: always use specific PDR ids for access and core Makes it easier to find the right one later. This will be used to fetch the UPF chosen TEIDs from PFCP responses in upcoming "n-sessions [4/4]" I74a21cc31296ab89a2acda1da8ae9693c1992e66. Related: SYS#6590 Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26 --- M src/osmo-pfcp-tool/pfcp_tool_vty.c 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve diff --git a/src/osmo-pfcp-tool/pfcp_tool_vty.c b/src/osmo-pfcp-tool/pfcp_tool_vty.c index f0a46f4..7f68ccf 100644 --- a/src/osmo-pfcp-tool/pfcp_tool_vty.c +++ b/src/osmo-pfcp-tool/pfcp_tool_vty.c @@ -397,6 +397,11 @@ return CMD_SUCCESS; } +enum pdr_id_fixed { + PDR_ID_CORE = 1, + PDR_ID_ACCESS = 2, +}; + int session_tunend_tx_est_req(struct vty *vty, const char **argv, int argc) { struct pfcp_tool_session *session = vty->index; @@ -475,7 +480,7 @@ .create_pdr_count = 2, .create_pdr = { { - .pdr_id = 1, + .pdr_id = PDR_ID_CORE, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_CORE, @@ -492,7 +497,7 @@ .far_id = 1, }, { - .pdr_id = 2, + .pdr_id = PDR_ID_ACCESS, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_ACCESS, @@ -635,7 +640,7 @@ .create_pdr_count = 2, .create_pdr = { { - .pdr_id = 1, + .pdr_id = PDR_ID_CORE, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_CORE, @@ -650,7 +655,7 @@ .far_id = 1, }, { - .pdr_id = 2, + .pdr_id = PDR_ID_ACCESS, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_ACCESS, -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26 Gerrit-Change-Number: 37756 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>