Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29409 )
Change subject: llc: separate enum osmo_gprs_llc_primitive to llc_prim.h
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I'm also wondering what the rationale of this is. […]
The idea is to avoid having one huge header file with everything this library provides. Currently it's just one enum, but next patch adds several structs. I am also planning to add some more API there, so I believe it makes sense.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/29409
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ida9ce56f48474313064d798ea7b9a72e9b99bb8d
Gerrit-Change-Number: 29409
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Thu, 22 Sep 2022 16:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment