fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27765 ) Change subject: rsl: misc / cosmetic fixes for tx_ipac_XXcx_nack() ...................................................................... rsl: misc / cosmetic fixes for tx_ipac_XXcx_nack() Change-Id: Ia7367cdfc6e1b1ebaabdf21e0a050fc1543968b2 --- M src/common/rsl.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/65/27765/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index 76a4c76..30b65fc 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -2647,15 +2647,15 @@ } -/* transmit an CRCX NACK for the lchan */ +/* Send an xxCX NACK for the given xxCX message type and lchan */ static int tx_ipac_XXcx_nack(struct gsm_lchan *lchan, uint8_t cause, int inc_ipport, uint8_t orig_msgtype) { struct msgb *msg; uint8_t chan_nr = gsm_lchan2chan_nr_rsl(lchan); + uint8_t msg_type = orig_msgtype + 2; - /* FIXME: allocate new msgb and copy old over */ - LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "RSL Tx IPAC_BIND_NACK\n"); + LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "RSL Tx %s\n", rsl_ipac_msg_name(msg_type)); msg = rsl_msgb_alloc(sizeof(struct abis_rsl_dchan_hdr)); if (!msg) @@ -2675,7 +2675,7 @@ msgb_tlv_put(msg, RSL_IE_CAUSE, 1, &cause); /* push the header in front */ - rsl_ipa_push_hdr(msg, orig_msgtype + 2, chan_nr); + rsl_ipa_push_hdr(msg, msg_type, chan_nr); msg->trx = lchan->ts->trx; return abis_bts_rsl_sendmsg(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia7367cdfc6e1b1ebaabdf21e0a050fc1543968b2 Gerrit-Change-Number: 27765 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange