fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32501 )

Change subject: virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req() ......................................................................

virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req()

Change-Id: If29ff1e9cc052576102094d870bf1710da562463 Related: OS#5500 --- M src/host/virt_phy/src/virt_prim_pdch.c 1 file changed, 15 insertions(+), 2 deletions(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved

diff --git a/src/host/virt_phy/src/virt_prim_pdch.c b/src/host/virt_phy/src/virt_prim_pdch.c index 7125a70..2cb3efd 100644 --- a/src/host/virt_phy/src/virt_prim_pdch.c +++ b/src/host/virt_phy/src/virt_prim_pdch.c @@ -56,12 +56,15 @@

if (OSMO_UNLIKELY(ms->gprs == NULL)) { LOGPMS(DL1P, LOGL_ERROR, ms, "l1gprs is not initialized\n"); + msgb_free(msg); return; }

msg->l1h = (void *)l1h->data; - if (l1gprs_handle_ul_block_req(ms->gprs, &req, msg) != 0) + if (l1gprs_handle_ul_block_req(ms->gprs, &req, msg) != 0) { + msgb_free(msg); return; + } msg->l2h = (void *)&req.data[0];

fn_sched = sched_fn_ul(ms->state.current_time, @@ -70,7 +73,7 @@ LOGPMS(DL1P, LOGL_ERROR, ms, "GPRS UL BLOCK.req: fn_sched(%u) != fn_req(%u)\n", fn_sched, req.hdr.fn); - /* FIXME: return; */ + /* FIXME: msgb_free(msg); return; */ }

virt_l1_sched_schedule(ms, msg, fn_sched, req.hdr.tn,