tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26833 )
Change subject: icE1usb fw: Remove useless variable in main loop ......................................................................
icE1usb fw: Remove useless variable in main loop
Left over from early testing code ...
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I242bbcd42ba96f56bf12bbe57537f3a72a44767b --- M firmware/ice40-riscv/icE1usb/fw_app.c 1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/33/26833/1
diff --git a/firmware/ice40-riscv/icE1usb/fw_app.c b/firmware/ice40-riscv/icE1usb/fw_app.c index eebc21f..39173f2 100644 --- a/firmware/ice40-riscv/icE1usb/fw_app.c +++ b/firmware/ice40-riscv/icE1usb/fw_app.c @@ -64,7 +64,6 @@
void main() { - bool e1_active = false; int cmd = 0;
/* Init console IO */ @@ -103,7 +102,6 @@
/* Start */ e1_init(0, 0); - e1_active = true; led_state(true); usb_connect();
@@ -153,9 +151,7 @@ usb_poll();
/* E1 poll */ - if (e1_active) { - e1_poll(); - usb_e1_run(); - } + e1_poll(); + usb_e1_run(); } }
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26833 )
Change subject: icE1usb fw: Remove useless variable in main loop ......................................................................
Patch Set 1: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26833 )
Change subject: icE1usb fw: Remove useless variable in main loop ......................................................................
icE1usb fw: Remove useless variable in main loop
Left over from early testing code ...
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I242bbcd42ba96f56bf12bbe57537f3a72a44767b --- M firmware/ice40-riscv/icE1usb/fw_app.c 1 file changed, 2 insertions(+), 6 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/firmware/ice40-riscv/icE1usb/fw_app.c b/firmware/ice40-riscv/icE1usb/fw_app.c index eebc21f..39173f2 100644 --- a/firmware/ice40-riscv/icE1usb/fw_app.c +++ b/firmware/ice40-riscv/icE1usb/fw_app.c @@ -64,7 +64,6 @@
void main() { - bool e1_active = false; int cmd = 0;
/* Init console IO */ @@ -103,7 +102,6 @@
/* Start */ e1_init(0, 0); - e1_active = true; led_state(true); usb_connect();
@@ -153,9 +151,7 @@ usb_poll();
/* E1 poll */ - if (e1_active) { - e1_poll(); - usb_e1_run(); - } + e1_poll(); + usb_e1_run(); } }