Attention is currently required from: laforge, keith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31916 )
Change subject: New osmo-gsmtap-logsend utility
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File utils/gsmtap-logsend.c:
https://gerrit.osmocom.org/c/libosmocore/+/31916/comment/bba1c8e4_74c1430a
PS2, Line 18: #include <string.h>
: #include <stdlib.h>
: #include <string.h>
: #include <fcntl.h>
apparently these 4 #includes are not needed.
(at least string.h is duplicated)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31916
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida96e87d84e0c349c5069edc67fec1c3cf19d1ab
Gerrit-Change-Number: 31916
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: keith
keith@rhizomatica.org
Gerrit-Comment-Date: Tue, 14 Mar 2023 20:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment