Change in libosmo-netif[master]: amr: osmo_amr_bwe_to_oa(): Modify loop to allow osmo_amr_bytes()=0 (N... - gerrit-log

20 Dec 2022


      Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30693 )
Change subject: amr: osmo_amr_bwe_to_oa(): Modify loop to allow osmo_amr_bytes()=0 (NO_DATA)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
sounds like the kind of bug that illustrates why unit tests for functions like this would be useful
The tests are added in a follow-up commit in the patchset. See https://gerrit.osmocom.org/c/libosmo-netif/+/30697/2/tests/amr/amr_test.c
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30693
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I1e513f493d7883a03acbfa3d9744ec63657810b3
Gerrit-Change-Number: 30693
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Tue, 20 Dec 2022 09:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Gerrit-MessageType: comment