Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36383?usp=email ) Change subject: contrib/jenkins.sh: add 'distcheck' job to check package integrity ...................................................................... Patch Set 2: (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/36383/comment/0a11ba60_9c520a53 PS2, Line 35: "distcheck") I'm not sure if we should call it "distcheck". It sounds like "make distcheck" from autotools, but it does something else here. Maybe smoketest? If you just want to print --help, maybe just add it at the end of the regular test job (since it will almost take no extra time, and then you can avoid having the test setup time)? Or is the idea to extend it later on and do more? https://gerrit.osmocom.org/c/pysim/+/36383/comment/1dc55eb1_c2b6502d PS2, Line 43: $prog --help > /dev/null why >/dev/null, wouldn't it be useful to have the output in jenkins, so one can take a look at it? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic72d58494e8fd0cab8d66ce60f7b70593b770872 Gerrit-Change-Number: 36383 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: char <osmocom(a)hypodyne.net> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Mar 2024 09:44:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment