Attention is currently required from: pespin.

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )

Change subject: transceiver: add optional WebSDR device support ......................................................................

Patch Set 8:

(11 comments)

File Transceiver52M/Transceiver.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/7dd9b4e2_23f7a737?usp=... : PS8, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/649bbb1a_e6cac59f?usp=... : PS8, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/e43cb7d8_83427de5?usp=... : PS8, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/5de8122d_d9c6ccc9?usp=... : PS8, Line 258: bool driveReceiveFIFO(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/064bb819_d68f620c?usp=... : PS8, Line 264: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/e6d84079_ce961bce?usp=... : PS8, Line 265: @param chan channel number please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b7a76b49_820d88e9?usp=... : PS8, Line 266: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/0ae2eab9_9259f206?usp=... : PS8, Line 267: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ba4924db_ca0b3164?usp=... : PS8, Line 270: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line

File Transceiver52M/radioInterface.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/be5f21a5_edd0a467?usp=... : PS8, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/0434ce0e_4e243025?usp=... : PS8, Line 137: int fillPullBuffer(std::vector<short *> &bufs, int samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line