[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPA - gerrit-log

31 Jul 2023


      Attention is currently required from: arehbein, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )
Change subject: stream: Add server-side (segmentation) support for IPA
......................................................................
Patch Set 13:
(1 comment)
File tests/stream/stream_test.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/80b6d596_0fdb4528 
PS10, Line 621: 	rc = clock_gettime(CLOCK_MONOTONIC, &start);
...
The advantage is not mixing the code testing the API with the test-code itself. […]
I agree that the error handling needed for clock_gettime() is not really nice. The default handler for SIGALARM is to terminate the program so that should work without any handler installed.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c
Gerrit-Change-Number: 33197
Gerrit-PatchSet: 13
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 31 Jul 2023 16:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein arehbein@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment