Attention is currently required from: fixeria.

osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email )

Change subject: doc/manuals: document the metrics ......................................................................

Patch Set 4:

(3 comments)

File doc/manuals/chapters/metrics.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/542970d8_68bed... : PS4, Line 5: https://github.com/Feuerlabs/exometer_core%5Bexometer_core] library. Two "OsmoS1GW exposes internal metrics using the

https://github.com/Feuerlabs/exometer_core%5Bexometer_core] library."

this seems unnecessary, given that it is mentioned in e.g. the configuration section already.

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/0345ea47_97504... : PS4, Line 25: is this explanation of how the stats are stored internally useful to the user?

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/7f319630_1d750... : PS4, Line 68: | `s1ap.proxy.in_pkt.erab_setup_req` | E-RAB SETUP REQUEST PDUs How about: ```suggestion | `s1ap.proxy.in_pkt.erab_setup_req` | Received E-RAB SETUP REQUEST PDUs

```

Same for all below with in_pkt.