Change in libosmocore[master]: coding: simplify detect_ahs_id_marker() - gerrit-log

27 Apr 2022


      Attention is currently required from: laforge, tnt, pespin, fixeria.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 )
Change subject: coding: simplify detect_ahs_id_marker()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
...
while I agree the function is now easier to read, the truth is you are adding 212 modulus operations […]
You're doing a bit-wise comparison of 212 conescutive bits, instead of just memcmping a few bytes, the % isn't the issue here...
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8
Gerrit-Change-Number: 27939
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Reviewer: tnt tnt@246tNt.com
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: tnt tnt@246tNt.com
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment