Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 ) Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31687/comment/c32a08e7_0582af2c PS2, Line 964: return -EINVAL; What are you doing? My concern was that there is already a message being printed (by the VTY code), but it does not say *what exactly is wrong*. It might not be obvious to the user/operator that only Ericsson RBS is supported, so we should make this clear in the logging message. See below: "Could not create unix socket", "Could not register listen"... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18d190d661b06015419078382915c4606be01b04 Gerrit-Change-Number: 31687 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 14:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment