Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33169 )
Change subject: fix umts_cell_id_name(): show CID ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33169/comment/11674beb_58da39d6 PS3, Line 12: Use OTC_SELECT
I'm also a bit worried about this change, depending on how often we end up logging the cell-ID. […]
That's usually my opinion too, but since I have the feeling I'm usually the only one against this I refrain from making the same comments again and again. But yeah, I second that and I would avoid heap allocation on code paths potentially used tons of times, like some function used to log some object.