Attention is currently required from: pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29760 )
Change subject: msgb: expand copy test
......................................................................
Patch Set 1:
(1 comment)
File tests/msgb/msgb_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/29760/comment/f82b0113_0394ecd3
PS1, Line 164: OSMO_ASSERT(msg->tail - msg->l4h == msg2->tail - msg2->l4h);
we don't have msgb_l4len()?
Perhaps it
wasn't there when the test was written?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29760
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199
Gerrit-Change-Number: 29760
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Oct 2022 10:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment