Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28039
)
Change subject: Update current NM object state before signalling S_NM_STATECHG
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
are we sure all users are fine with that kind of
change? esentially the old signal is a 'pre-state-c […]
I checked all users and
I couldn't find any issue. None seems to be using the current state in signal
changers, and that's precisely because it didn't make sense before. The use of
pre-state was precisely preventing to use it in a way which made sense.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28039
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba
Gerrit-Change-Number: 28039
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 06 May 2022 12:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment