Attention is currently required from: neels, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30703 )
Change subject: libosmocore: Deprecate APIs telnet_init(_dynip)()
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS4:
FYI, you cannot change patches that have been merged
to master. […]
Thanks for the info neels, makes sense
File src/vty/telnet_interface.c:
https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/e577a4d1_f85018b7
PS4, Line 45: \ref
('\ref' is to reference files, not functions.
we've been using it wrongly for some time. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/3f246a06_60140ba6
PS4, Line 96: \deprecated
(interesting, i wasn't aware of the \deprecated
cmd yet)
Saw it used somewhere else in our codebase while grepping for the word in
order to see how we deprecate functions :)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30703
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454
Gerrit-Change-Number: 30703
Gerrit-PatchSet: 6
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Jan 2023 17:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment