Attention is currently required from: laforge, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: RFC: lint: annotate lines in gerrit ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/4984745d_651384f5 PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh I don't think the complexity of the extra job is worth it (and to do it right, if we do allow untrusted input for the review json, it would be a good idea to do a sanity check on the json file too before passing it to the gerrit review command...). Therefore I suggest to continue as follows: * gerrit-lint.yml: replace " - shell: '{obj:cmd}'" with " - shell: '~/osmo-ci/lint/lint_diff.sh HEAD~1'", then remove the "cmd" variable in that file so it cannot be overridden * create a gerrit user that has permission only to provide review * configure jenkins to have permissions to that gerrit/ssh user File lint/checkpatch/checkpatch_json.py: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/3cf12757_b0228386 PS1, Line 3: # from coreboot rev 9cae17d028d4bd3b278fc89ada8e06287917e213 I'd note the exact commit in the commit message, but not in the file. Otherwise we might update/change the file later on and forget to update the revision string here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 25 Mar 2022 10:56:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment