laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35937?usp=email ) Change subject: xua_asp_fsm: Log ERROR message when we send a MGMT:ERR message ...................................................................... xua_asp_fsm: Log ERROR message when we send a MGMT:ERR message We've always been logging received MGMT:ERR messages, but we somehow didn't log the transmission of them. So whenever osmo-stp generates some error to a connected peer, the peer would show it, but not osmo-stp itself. Let's fix that. Change-Id: I50c05409646fd47e70d904fb95bbc2fa15703b3e --- M src/xua_asp_fsm.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 701e081..8bb5b64 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -293,6 +293,8 @@ struct xua_msg *xua = xua_msg_alloc(); struct msgb *msg; + LOGPFSML(fi, LOGL_ERROR, "Tx MGMT_ERR '%s'\n", get_value_string(m3ua_err_names, err_code)); + xua->hdr = XUA_HDR(SUA_MSGC_MGMT, SUA_MGMT_ERR); xua->hdr.version = SUA_VERSION; xua_msg_add_u32(xua, SUA_IEI_ERR_CODE, err_code); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I50c05409646fd47e70d904fb95bbc2fa15703b3e Gerrit-Change-Number: 35937 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged