Change in osmo-mgw[master]: Get rid of separate rtp_port field - gerrit-log

4 Oct 2022


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29589 )
Change subject: Get rid of separate rtp_port field
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/mgcp/mgcp_network.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29589/comment/fd74657d_4b96cf9c 
PS3, Line 96: int rtp_port, rtcp_port
To me it looks like it was done on purpose: there is not only rtp_port, but also rtcp_port. Now you're moving one port to osmo_sockaddr, while this one remains separate. This introduces inconsistency.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29589
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I294eb5d85fae79bf62d36eb9e818426e187d442c
Gerrit-Change-Number: 29589
Gerrit-PatchSet: 3
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 04 Oct 2022 15:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment