Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email )

Change subject: fixup: rsl: properly initialize MS/BS Power Control state ......................................................................

Patch Set 1:

(1 comment)

File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/9b54eee8_3c65eb47?usp=... : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;

Before, we were doing it in the branch TLVP_PRES_LEN() ...

``` /* Initialize MS Power Control defaults */ lchan->ms_power_ctrl = (struct lchan_power_ctrl_state) { .max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0), .current = lchan->ms_power_ctrl.max, }; ```

As explained in COMMIT_MSG, the intention was to set `current = max`.

Before `75162427ad26b9834433757b790a29f4995b9b60`, it was done as follows:

``` /* Initialize MS Power Control defaults */ lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; lchan->ms_power_ctrl.fixed = true; ```