Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email )

Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ......................................................................

Patch Set 1:

(3 comments)

File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/af53d59f_75b2c43a?usp=... : PS1, Line 918: static int gsm48_cc_tx_setup_set_bearer_cap(struct gsm_trans *trans, const struct gsm_mncc *setup,

Since we have 2 inout pars and 1 in par, please move the in par to the end instead of having it in t […]

Ack. This ordering is influenced by the Intel assembly flavor ;)

https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/80f4690f_703fb703?usp=... : PS1, Line 945: rc `rc` is set but not used here

https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/c7bc73b9_65460967?usp=... : PS1, Line 971: rc `rc` is set but not used here