Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27644 )
Change subject: rsl: Fix tlv_parse of IPAC_DLCX_IND message
......................................................................
Patch Set 1:
(1 comment)
File tests/abis/abis_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/27644/comment/6eecb9b0_0bfb6ee8
PS1, Line 251: sys5915
I don't think it's a good idea to use/mention
Sysmocom's internal ticket numbers in the code, becaus […]
It is still fine to
add a suffix to it in case we want to test decoding same message type using different
content. I could have added a "potato" suffix to identify the test, but using a
ticket number is more useful, even if some people cannot access it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27644
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib637197ef3508ec94aec05d08d4e6aa15ddea055
Gerrit-Change-Number: 27644
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Apr 2022 10:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment