lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39064?usp=email )

(

3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack ......................................................................

RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack

When changweights of a NS-VC via SNS, the SNS Ack should only contains the IEs "List of IP4/6 elements" if the cause code is Unknown IP endpoint.

However the libosmocore/ns2 code isn't following this behavior yet.

Change-Id: Ibf00cbab0c6691cdb72fe592ee30e122dd8f4783 --- M library/RAW_NS.ttcnpp 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified

diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp index 5f0e421..a7cdb8a 100644 --- a/library/RAW_NS.ttcnpp +++ b/library/RAW_NS.ttcnpp @@ -579,13 +579,13 @@ nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit, omit)); } }