Attention is currently required from: jolly, neels, nt2mku.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email )

Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station ......................................................................

Patch Set 1:

(8 comments)

File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/8d2c09cf_0f3c80c0?usp=... : PS1, Line 929: /* Remove codecs in bearer_cap that are unsupported by phase 1 mobile stations. It probably makes sense to move this to a helper function, eg bearer_cap_filter_rev_lev(sutrct gsm_mncc_bearer_cap *bearer_cap, unsigned rev_len);

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/58108fe0_9e5d3c8d?usp=... : PS1, Line 990: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/851005b8_8b6e2404?usp=... : PS1, Line 992: if (trans->vsub->classmark.classmark1.rev_lev == 0) I guess you could do this in the GSM48_BCAP_ITCAP_SPEECH code path above?

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/e7bd8c28_e8d4e767?usp=... : PS1, Line 1158: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/85b6308d_0c6a655a?usp=... : PS1, Line 1878: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/be1dd5a7_f750d7c7?usp=... : PS1, Line 1930: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/3eeed32e_c0886c4f?usp=... : PS1, Line 1988: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets

https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/262c1abf_059b30de?usp=... : PS1, Line 1991: modify->bearer_cap.speech_ver[0] = -1; I see this being done in lots of places, it may make sense to move the logic to a helper function to have it once so it can easily be identified when this logic is used.