Attention is currently required from: jolly, neels, nt2mku.

View Change

8 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #1, Line 929: /* Remove codecs in bearer_cap that are unsupported by phase 1 mobile stations.

    It probably makes sense to move this to a helper function, eg
    bearer_cap_filter_rev_lev(sutrct gsm_mncc_bearer_cap *bearer_cap, unsigned rev_len);

  • Patch Set #1, Line 990: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

  • Patch Set #1, Line 992: if (trans->vsub->classmark.classmark1.rev_lev == 0)

    I guess you could do this in the GSM48_BCAP_ITCAP_SPEECH code path above?

  • Patch Set #1, Line 1158: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

  • Patch Set #1, Line 1878: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

  • Patch Set #1, Line 1930: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

  • Patch Set #1, Line 1988: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

  • Patch Set #1, Line 1991: modify->bearer_cap.speech_ver[0] = -1;

    I see this being done in lots of places, it may make sense to move the logic to a helper function to have it once so it can easily be identified when this logic is used.

To view, visit change 38197. To unsubscribe, or for help writing mail filters, visit settings.