Attention is currently required from: pespin, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky ......................................................................
Patch Set 7:
(1 comment)
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/befb4ad9_399120e4 PS7, Line 389: guess = (src->ss_family == AF_UNSPEC) ? osmo_sockaddr_guess_unspec((const struct sockaddr *)src) : src->ss_family;
This all looks wrong to me, or I'm missing soemthing. […]
Not "random stuff" but the content withdots or colons which passed through osmo_sockaddr_guess_unspec(). The random stuff would still likely get AF_UNSPEC and won't be converted/printed. As the comment says: we relax restrictions, we do not remove them completely.
-
msuraev