Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30685 )
Change subject: osmo_stream_srv_link_close(): properly handle NULL input ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not a big fan of this kind of null-return code paths for non-free function, in general I think c […]
I think library shouldn't suddenly crash it's user due to omitted NULL-check. Especially when it doesn'[t make call semanticallz incorrect.
In general crashing the user app when library can avoid it requires additional debugging efforts and is unnecessary waste of time. See recent 5a513317292280aad8b9f81e1e1159153bd5ed4d in libosmocore for example.