Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `imsi unknown cause` to set the reject cause ......................................................................

Patch Set 6: Code-Review-1

(2 comments)

Patchset:

PS6: CR-1 for incomplete command description. Try running osmo-hlr with this patch, enter the VTY interface and check help ('?') for all components of the new command. You should see something like this:

OsmoHLR(config-hlr)# imsi? Define the GSUP cause to be send in case the IMSI could not found in the database. OsmoHLR(config-hlr)# imsi unknown? Default is imsi-unknown. OsmoHLR(config-hlr)# imsi unknown cause? NULL OsmoHLR(config-hlr)# imsi unknown cause ? NULL

I am surprised why Jenkins does not catch this. Usually it does.

File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/95854688_b8539486 PS6, Line 381: imsi unknown cause Here I would recommend concatenating all three words using '-', i.e. 'imsi-unknown-cause'. Otherwise the VTY engine requires you to provide help strings for each separate word in the command. Ah, actually I already suggested using 'subscriber-reject-cause' in one of my previous comments.